Nice draft, a note though:
The v:variable.set -> f:variable change could cause issues, when used with multi dimensional
so v:variable.set name="foo.bar" won't work with f:variable name="foo.bar" from my experience

@kitzberger Nice. What we will also need are tests. Could you provide them?

@kitzberger Nice. What we will also need are tests. Could you provide them?

@sabbelasichon, like this? Any suggestions? I know, one is failing. I need to figure out how to migrate single viewhelper properties.

Nice draft, a note though: The v:variable.set -> f:variable change could cause issues, when used with multi dimensional so v:variable.set name="foo.bar" won't work with f:variable name="foo.bar" from my experience

@helsner, good point. Is there a way of migrating the code and print some warning in such a case? Or is that counter-productive since nobody every reads them anyways?

I would say there is no proper way of migration as the logic behind the var cannot be further checked (especially in HTML).
A warning should be possible and the prevention of changing the viewhelper call in case there is a dot within the name mandatory.
As we don't change the code then, it should already be good, in case the warning is ignored we don't destroy functionality and I cannot help people that ignore our notice 🤷

Do you know of any examples where a warning is being output? Thanks for your input :-)

Do you know of any examples where a warning is being output? Thanks for your input :-)

simply look for rectorOutputStyle in existing rules.
It's basically used via constructor and ...->warning() call most of the times

@helsner, thanks for the hint!

I've now added a more strict pattern to detect the simple cases like: v:variable.set name="xx" and migrate only those automatically. Any left occurrences of v:variable.set I keep untouched and print a warning instead.

What do you think?

@kitzberger nice, but i would point out to why the change is not made as well, as this might not be known (i found that out the hard way 😂 )

This still looks great, but i just checked and noticed that we have some TODO's left

This still looks great, but i just checked and noticed that we have some TODO's left

Nice PR, do you know when it'll be ready to merge?

Thanks,

@helsner What kind of TODO´s are left here?

@helsner What kind of TODO´s are left here?

Those marked in the code I guess
Maybe we can still merge and they will be added afterwards
But usually we migrate fully because it would cause too much frustration not handling attributes etc

@helsner If you like you can merge it. I am not using VHS anyways ;-)

@kitzberger what about you Philipp?
are you ready to merge?